Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wildcard search message #2029 #2048

Closed
wants to merge 2 commits into from
Closed

Add wildcard search message #2029 #2048

wants to merge 2 commits into from

Conversation

kellyjacksonio
Copy link

@kellyjacksonio kellyjacksonio commented Jan 18, 2018 •
edited
Loading

Fixes #2029

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

[x] all tests pass -- rake test:all
[x] code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
[x] pull request is descriptively named with #number reference back to original issue
Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.

Thanks!

@PublicLabBot
Copy link

PublicLabBot commented Jan 18, 2018 •
edited
Loading

1 Error
🚫
There was a test failure at: Failure: test_validate_unused_tag(Minitest::Result) [/app/test/functional/tag_controller_test.rb:42]: expected tag, but no tag found matching {:tag=>”p”, :child=>/No contributors for that tag/} in: “<!DOCTYPE html>\n<html lang="en">\n <head>\n <meta charset="utf-8" />\n <title>🎈 Public Lab: Contributors</title>\n <meta name="viewport" content="width=device-width, initial-scale=1.0" />\n <meta name="description" content="Public Lab is an open community which collaboratively develops accessible, open source, Do-It-Yourself technologies for investigating local environmental health and justice issues." />\n <meta name="author" content="Public Lab contributors" />\n <link href="https://test.host/feed.rss" rel="alternate" type="application/rss+xml" title="Public Lab research" />\n\n <link rel="apple-touch-icon" href="/images/pl-255.png">\n <link rel="apple-touch-icon-precomposed" href="/images/pl-255.png">\n <link rel="apple-touch-icon-precomposed apple-touch-icon" href="/images/pl-255.png">\n <link rel="shortcut icon" href="/images/pl-255.png" />\n <script type="text/javascript" async\n src="https://cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-MML-AM_CHTML">\n </script>\n\n <link href="/assets/application.css" media="all" rel="stylesheet" />\n <link href="/lib/fontawesome/css/font-awesome.min.css" media="all" rel="stylesheet" type="text/css" />\n <link href="/assets/print.css" media="print" rel="stylesheet" />\n\n \n \n\n <script src="/assets/application.js"></script>\n \n <meta name="google-translate-customization" content="4ce4c7c384354172-5179499fc244f592-g2b333d0d29f59663-d" />\n\n \n\n <script type="text/javascript">\n I18n.defaultLocale = "en";\n I18n.locale = "en";\n I18n.fallbacks = true;\n </script>\n\n \n\n </head>\n\n <body>\n\n \n\n\n\n<p class="facebook-summary" style="display:none;">Public Lab is an open community which collaboratively develops accessible, open source, Do-It-Yourself technologies for investigating local environmental health and justice issues.</p>\n\n\n<div id="fb-root"></div>\n\n<nav id="header" class="navbar navbar-inverse navbar-fixed-top" style="margin-bottom:20px;">\n\n <div class="container">\n\n\n <!–     menu, displayed for mobile: –>\n <div class="navbar-header">\n <a class="navbar-brand" id="brand" href="/home">Public Lab</a>\n <a class="navbar-brand brand-compact" id="brand-compact" href="/home">PL</a>\n <a class="navbar-brand home-icon visible-xs" href="/"><i class="fa fa-home fa fa-white"></i></a>\n\n <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#header-navbar-collapse">\n <span class="fa fa-white fa-bars"></span>\n </button>\n </div>\n\n\n <div class="collapse navbar-collapse" id="header-navbar-collapse">\n\n <ul class="nav navbar-nav navbar-left">\n\n <li><a rel="tooltip" title="Your dashboard" data-placement="bottom" href="/dashboard"><i class="fa fa-home fa fa-white"></i></a></li>\n\n <li class="dropdown">\n\n <a class="dropdown-toggle" data-toggle="dropdown" href="#">\n Get Involved <b class="caret"></b>\n </a>\n\n <ul class="dropdown-menu">\n <li><a href="/events">Meet people</a></li>\n <li><a href="/lists">Join the discussions</a></li>\n <li><a href="/chat">Chat online</a></li>\n <li><a href="/wiki/requests">Browse requests</a></li>\n <li><a href="/dashboard">See the latest research</a></li>\n <li><a href="/methods">Discover methods</a></li>\n <li><a href="/questions">Ask a question</a></li>\n <li><a href="/post">Post your work</a></li>\n <li class="hidden-lg hidden-xl"><a href="/donate">Donate</a></li>\n </ul>\n\n </li>\n </ul>\n\n <form id="searchform" class="navbar-form navbar-left" role="search" autocomplete="off">\n <div class="form-group">\n <input tabindex="1" id="searchform_input" type="text" class="form-control search-query typeahead" qryType="all" placeholder="Search"/>\n </div>\n <button type="submit" class="btn btn-primary" style="background:#444;border-color:#222;"><i class="fa fa-search"></i></button>\n </form>\n\n <ul class="nav navbar-nav">\n\n <li class="dropdown hidden-xs hidden-sm">\n <a class="dropdown-toggle" data-toggle="dropdown" href="#">\n About <b class="caret"></b>\n </a>\n <ul class="dropdown-menu">\n <li><a href="/wiki/stories">Stories</a></li>\n <li><a href="/blog">Blog</a></li>\n <li><a href="/about">About Public Lab</a></li>\n <li class="divider"></li>\n <li><a href="/wiki/plots-staff">Non-profit team</a></li>\n <li><a href="/wiki/organizers">Organizers</a></li>\n <li><a href="/wiki/board">Non-profit board</a></li>\n <li><a href="/wiki/how-we-are-funded">How we're funded</a></li>\n <li class="divider"></li>\n <li><a href="/media">Press and Media</a></li>\n <li><a href="/wiki/contact">Contact the staff</a></li>\n <li class="hidden-lg hidden-xl"><a href="//store.publiclab.org">Store</a></li>\n </ul>\n </li>\n\n <li class="nav-button-wrapper hidden-xs hidden-sm hidden-md">\n <a class="btn btn-sm btn-default nav-button-store" href="//store.publiclab.org">Store</a>\n </li>\n </ul>\n\n\n <div id="chat" class="chat-popover" data-placement="bottom" style="display:none;">\n <a style="margin-right:4px;" class="pull-right btn btn-sm" href="https://chat.publiclab.org" target="_blank">pop out</a>\n <p class="popover-title">Public Lab chatroom</p>\n\n </div>\n\n \n <div class="nav-button-wrapper hidden-xs hidden-sm hidden-md navbar-right">\n <a class="btn btn-sm nav-button-donate" href="/donate">Donate</a>\n </div>\n <ul class="nav navbar-nav navbar-right">\n <li class="dropdown">\n <a id="chat-button">\n <i class="fa fa-white fa fa-comments"></i>\n </a>\n </li>\n <li class="dropdown">\n <a href="#" class="dropdown-toggle" data-toggle="dropdown">\n <i class="fa fa-user fa fa-white"></i>\n <b class="caret"></b>\n </a>\n <ul class="dropdown-menu">\n <li class="dropdown-header">Bob</li>\n <li><a href="/dashboard">Dashboard</a></li>\n <li><a href="/profile/Bob">Profile</a></li>\n <li><a href="/profile/edit">Edit Profile</a></li>\n <li class="divider"></li>\n <li><a href="/subscriptions">Subscriptions</a></li>\n <li><a href="/profile/Bob/likes">Notes you've liked</a></li>\n <li class="divider"></li>\n <li><a href="/logout">Logout</a></li>\n <li><a href="/logoutRemotely">Logout from all devices</a></li>\n </ul>\n </li>\n </ul>\n </div>\n </div>\n</nav>\n\n<div class="body-container container">\n\n <div class="visible-print">\n \n \n <hr />\n </div>\n <script>\n $('#chat-button').click(function(e){\n e.stopPropagation() ;\n });\n $('body').click(function(){\n var c = $('#chat') ;\n if($('#chat').is(':visible') == true)\n c.hide() ;\n });\n</script>\n <div id="alert-placeholder"></div>\n\n\n\n\n\n\n\n \n\n\n</div>\n\n\n <div class="container">\n <div class="row">\n\n <div class="col-md-3 hidden-print">\n\n <a style="margin-top:-16px;margin-bottom:0;" class="btn btn-mini btn-block btn-link visible-xs visible-sm" href="javascript:void()" onClick="toggle_sidebar()"><i class="fa fa-chevron-down"></i></a>\n\n <div id="sidebar" class="hidden-xs hidden-sm">\n\n <a style="margin-bottom:6px;white-space: normal;" rel="tooltip" title="Share your work with others" data-placement="bottom" href="/post" class="btn btn-primary btn-lg btn-block hidden-sm"><i class="fa fa-pencil fa fa-white"></i> Write a research note</a>\n <a style="white-space: normal;" rel="tooltip" title="Post about " data-placement="bottom" href="/post?template=question&tags=question:general," class="btn btn-primary btn-lg btn-block"><i class="fa fa-pencil fa fa-white"></i> Ask a related question »</a>\n\n \n\n\n\n\n\n\n\n\n\n\n\n <hr style="margin-bottom:6px;" />\n\n </div>\n</div>\n<script src="/assets/sidebar.js"></script>\n\n<div class="col-md-9">\n <hr />\n\n <p>This is a wildcard tag search.</p>\n <p>Wildcard tag searches use the * asterisk in their URLs, and do not show contributor listings.<p>\n\n <hr />\n \n</div>\n\n\n </div>\n </div>\n\n <footer class="footer">\n <div class="col-md-3 hidden-print">\n <p>Getting help</p>\n <ul>\n <li><a href="/wiki/issues" > Report a bug or issue </a></li>\n <li><a href="mailto:web@test.host"> Email the Web working group </a></li>\n <li> PublicLab.org is open source software - and looking for contributors </li>\n </ul>\n \n </div>\n <div class="col-md-3 hidden-print">\n <p>Links</p>\n <ul>\n <li><a href="/about">About</a></li>\n <li><a href="/wiki/getting-started">Getting Started</a></li>\n <li><a href="/wiki/licenses">Licenses</a></li>\n <li><a href="/lists">Discussion lists</a></li>\n <li><a href="/stats">Site statistics</a></li>\n <li><a href="/feed.rss">RSS</a></li>\n </ul>\n </div>\n <div class="col-md-3">\n <p><a rel="license" href="http://creativecommons.org/licenses/by-sa/3.0/"><i class="fa fa-creative-commons"></i></a> This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 Unported License. Hardware designs on this site are released under the CERN Open Hardware License 1.1. Read more about Public Lab’s open source licensing here. </p>\n </div>\n <div class="col-md-3 hidden-print">\n <p>Specific works on this site may be released or dedicated under different licenses, but only if such alternatives are clearly indicated by their authors.</p>\n <p>This site makes extensive use of the open source font Junction.</p>\n <p>PublicLab.org is hosted through a donation of server space by Rackspace.</p>\n <ul class="dropdown">\n <a class="dropdown-toggle" data-toggle="dropdown" href="#">\n <i class="fa fa-language" aria-hidden="true"></i>\n Language <b class="caret"></b>\n </a>\n <ul class="dropdown-menu">\n <li><a href="/change_locale/en">English</a></li>\n <li><a href="/change_locale/de">Deutsch</a></li>\n </ul>\n </ul>\n </div>\n <br style="clear:both;" />\n</footer>\n\n\n <script src="https://maps.googleapis.com/maps/api/js?libraries=places&language=en&key=AIzaSyDWgc7p4WWFsO3y0MTe50vF4l4NUPcPuwE"></script>\n </body>\n</html>\n”
2 Messages
📖 @kellyjacksonio Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.

Generated by 🚫 Danger

@kellyjacksonio kellyjacksonio changed the title Add @wildcard to def contributors #2029 Add wildcard search message #2029 Jan 18, 2018
jywarren
jywarren reviewed Jan 19, 2018
View reviewed changes
app/views/tag/contributors.html.erb
@@ -57,8 +57,9 @@
<% end %>
<hr />

<% if @notes.nil? || @notes.length == 0 %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think perhaps we still need this line in case there is no wildcard but also no contributors. But it could be moved under the if @wildcard condition into an else if @notes.nil? || @notes.length == 0 conditional -- how does that sound?

@jywarren
Copy link
Member

Ah, and I think that will also resolve the error you're seeing! [/app/test/functional/tag_controller_test.rb:42]: expected tag, but no tag found matching {:tag=>”p”, :child=>/No contributors for that tag/} in: is the key to this error.

@jywarren
Copy link
Member

Thanks a lot for your contribution, this is almost there!

@jywarren
Copy link
Member

Hi, just checking if you've gotten stuck on this at all, or if I could help in any way? Thanks!

@jywarren jywarren mentioned this pull request Jan 26, 2018
Closed
@jywarren
Copy link
Member

Hi, @kellyjacksonio -- thanks for your help and if you're interested in contributing we have more open issues over at https://publiclab.github.io/community-toolbox/#r=all

However, we're going to go ahead and merge in #2029 to resolve this. Happy to work with you on any future issues and thanks again!!!

@jywarren jywarren closed this Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren jywarren left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kellyjacksonio @PublicLabBot @jywarren